Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate the ssl command #5068

Merged
merged 5 commits into from
Jan 2, 2024
Merged

chore: deprecate the ssl command #5068

merged 5 commits into from
Jan 2, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Dec 12, 2023

This SSL command is largely redundant now that framework tooling has better support for SSL.

Developers using Vite should leverage the http config option as well as @vitejs/plugin-basic-ssl.

Developers using Angular CLI should leverage the --ssl flag when serving. Alternatively, developers can update angular.json to provide this configuration.

Developers can also use https://github.com/FiloSottile/mkcert to generate locally-trusted development certificates. See https://web.dev/articles/how-to-use-local-https for a tutorial.

@jcesarmobile
Copy link
Member

jcesarmobile commented Dec 12, 2023

There is a group called MetadataGroup.DEPRECATED, that I think you can use for this purpose without the need of changing texts manually. You just change the MetadataGroup.EXPERIMENTAL with MetadataGroup.DEPRECATED and it changes the text from (experimental) Generates an SSL key & certificate to (deprecated) Generates an SSL key & certificate, also the experimental/deprecated text has a different color than the rest of the description.

@liamdebeasi liamdebeasi changed the title chore: deprecate the ssl command chore: deprecate the ssl commands Dec 12, 2023
@liamdebeasi liamdebeasi changed the title chore: deprecate the ssl commands chore: deprecate the ssl command Dec 12, 2023
@liamdebeasi liamdebeasi merged commit 2e3a5de into develop Jan 2, 2024
4 checks passed
@liamdebeasi liamdebeasi deleted the deprecate-ssl branch January 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants